[docs] Add accessible label to demo Dialog's textarea#4279
Merged
michaldudak merged 1 commit intomui:masterfrom Mar 6, 2026
Merged
[docs] Add accessible label to demo Dialog's textarea#4279michaldudak merged 1 commit intomui:masterfrom
michaldudak merged 1 commit intomui:masterfrom
Conversation
michaldudak
added
docs
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
approved these changes
Mar 6, 2026
Contributor
atomiks
left a comment
atomiks
left a comment
There was a problem hiding this comment.
Aaron & Colm are re-doing docs and demos so there might be conflicts, but it's easy enough for LLMs to fix conflicts now for no effort, so I think we can still fix the a11y issues here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels the Dialog's textarea in the https://deploy-preview-4279--base-ui.netlify.app/react/components/dialog#close-confirmation demo with the Title element
Closes #4251